Add more benchmark tests to path/posix #11137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn is_ancestor_of_path_with_10_dirs(bh: &mut BenchHarness) { | ||
| let posix_path = Path::new("/home/1/2/3/4/5/6/7/8/9"); | ||
| bh.iter(|| { | ||
| posix_path.is_ancestor_of(&Path::new("/home/1/2/3/4/5/6/7/8")); |
There was a problem hiding this comment.
This is going to construct a new path in the hot loop, which is going to skew the benchmark. Move it out of the closure.
There was a problem hiding this comment.
Yes, that's correct. Let me fix it.
|
@cmr 👍 |
Benchmark testing `is_ancestor_of` and `path_relative_from`
bors
added a commit
that referenced
this pull request
Jan 1, 2014
Benchmark testing `is_ancestor_of` and `pop` ref: #9694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark testing
is_ancestor_ofandpopref: #9694