-
Notifications
You must be signed in to change notification settings - Fork 13.3k
libstd doc: uniform modules titles #11134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -8,7 +8,7 @@ | |||
// option. This file may not be copied, modified, or distributed | |||
// except according to those terms. | |||
|
|||
//! Utilities for manipulating the char type | |||
//! Utilities for manipulating UTF-8 characters (`char` type) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent with at_vec; I prefer the at_vec style (just char
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it back; fix at_vec, not the rest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it should be "Unicode characters" or "codepoints"? UTF-8 is just an encoding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual calls them "Unicode characters", and so will I.
Thanks! r+ once the nits are fixed. |
I am a bit concerned about prefixes like "Utilities for" because I think they bear a reading cost when browsing the index while not providing much information in return. |
@kud1ing++ I personally think that modules that actually define the types in question (e.g. Option, Either etc) are not just "utilities". (They could just be e.g. "the Option type to represent nullable values".) |
@lucab needs a rebase |
Rebased. |
This commit uniforms the short title of modules provided by libstd, in order to make their roles more explicit when glancing at the index. Signed-off-by: Luca Bruno <[email protected]>
Oh my bad, a trailing whitespace. Fixed. |
Uniform the short title of modules provided by libstd, in order to make their roles more explicit when glancing at the index.
Fix/11134 Fix rust-lang#11134 Hir of `qpath` will be `TypeRelative(Ty { kind: Path(LangItem...` when a closure contains macro (e.g. rust-lang/rust-clippy#11651) and rust-lang#11134, it causes panic. This PR avoids panicking and emitting incomplete path string when `qpath` contains `LangItem`. changelog: none
Uniform the short title of modules provided by libstd, in order to make their roles more explicit when glancing at the index.