change result::collect to take an iterator, and adds option::collect #11098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be a little tempted to implement these with I'm hesitant to add What do you think about using |
|
@alexcrichton: I'd be okay with changing over to |
|
I would personally rather see a nicer implementation because this doesn't seem particularly common or the possible root cause of slowdown in an application, but I could be wrong. |
|
With a squash to one commit, r=me |
bors
added a commit
that referenced
this pull request
Dec 28, 2013
This patch changes `result::collect` (and adds a new `option::collect`) from creating a `~[T]` to take an `Iterator`. This makes the function much more flexible, and may replace the need for #10989. This patch is a little more complicated than it needs to be because of #11084. Once that is fixed we can replace the `CollectIterator` with a `Scan` iterator. It also fixes a test warning.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 14, 2023
[`unnecessary_literal_unwrap`]: also lint `unwrap_(err_)unchecked` Closes rust-lang#11093 changelog: [`unnecessary_literal_unwrap`]: also lint `unwrap_unchecked` and `unwrap_err_unchecked`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes
result::collect(and adds a newoption::collect) from creating a~[T]to take anIterator. This makes the function much more flexible, and may replace the need for #10989.This patch is a little more complicated than it needs to be because of #11084. Once that is fixed we can replace the
CollectIteratorwith aScaniterator.It also fixes a test warning.