Add read_to_str and write_{str, line} #10861
Merged
+73
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// # Failure | ||
| /// | ||
| /// This function will raise all the same conditions as the `read` method, | ||
| /// along with raising a condition if the input is not valid utf-8. |
There was a problem hiding this comment.
The capitalisation of utf-8 is inconsistent.
|
Bump. I would love to have these methods back. I was using them before they disappeared, and the documentation in |
|
Agreed with @huonw. r=me with those changes. |
These methods are sorely needed on readers and writers, and I believe that the encoding story should be solved with composition. This commit adds back the missed functions when reading/writing strings onto generic Readers/Writers.
bors
added a commit
that referenced
this pull request
Jan 3, 2014
These methods are sorely needed on readers and writers, and I believe that the encoding story should be solved with composition. This commit adds back the missed functions when reading/writing strings onto generic Readers/Writers.
|
Thanks for fixing this. I have just noticed that there also used to be |
|
Ah I guess I missed that! Pull requests are welcome though! I'll see if I can get around to it soon. |
|
I will try and send a pull request in the next day or two. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 30, 2023
new lint [`single_call_fn`] Closes rust-lang#10861 changelog: New lint [`single_call_fn`]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are sorely needed on readers and writers, and I believe that the
encoding story should be solved with composition. This commit adds back the
missed functions when reading/writing strings onto generic Readers/Writers.