Add some more commentary to FFI tutorial. #10822
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -206,12 +215,17 @@ impl<T: Send> Unique<T> { | |||
| } | |||
| } | |||
|
|
|||
| // The key ingredient for safety, we associate a destructor with | |||
| // Unique<T>, making the struct manage the raw pointer. | |||
There was a problem hiding this comment.
Is it worth being specific about what sort of management is happening? "making the struct free the raw pointer when the struct goes out of scope", maybe?
|
Let me know if you want me to rebase these into one commit. |
|
@ezyang: one commit would be nicer imo, but it's not incredibly important |
Signed-off-by: Edward Z. Yang <[email protected]>
bors
added a commit
that referenced
this pull request
Dec 10, 2013
Signed-off-by: Edward Z. Yang <[email protected]>
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 2, 2023
Ignore `#[cfg]`'d out code in `needless_else` changelog: none (same release as rust-lang#10810) `#[cfg]` making things fun once more This lead me to think about macro calls that expand to nothing as well, but apparently they produce an empty stmt in the AST so are already handled, added a test for that r? `@llogiq`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Edward Z. Yang [email protected]