linkat() not available in the system headers of Solaris 10 #105007

dlaugt · 2022-11-28T10:02:04Z

I've installed rustup on x86_64-unknown-linux-gnu and would like to use the target sparcv9-sun-solaris. For this, I have built a gcc from the source code for cross-compiling to sparcv9-sun-solaris2.10 with system headers of Solaris 10.

With the following hello word example:
main.rs:

fn main() {
    println!("Hello, world!");
}

I had a compilation error:

$ rustc -v --target sparcv9-sun-solaris -C linker=/opt/cross-solaris/gcc730/bin/sparcv9-sun-solaris2.10-gcc main.rs
error: linking with `/opt/cross-solaris/gcc730/bin/sparcv9-sun-solaris2.10-gcc` failed: exit status: 1
  |
  = note: "/opt/cross-solaris/gcc730/bin/sparcv9-sun-solaris2.10-gcc" "-m64" "/tmp/rustcgebYgj/symbols.o" "main.main.89363361-cgu.0.rcgu.o" "main.main.89363361-cgu.1.rcgu.o" "main.main.89363361-cgu.2.rcgu.o" "main.main.89363361-cgu.3.rcgu.o" "main.main.89363361-cgu.4.rcgu.o" "main.main.89363361-cgu.5.rcgu.o" "main.csypsau9u2r8348.rcgu.o" "-Wl,-z,ignore" "-L" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib" "-Wl,-Bstatic" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/libstd-fa47c8247d587714.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/libpanic_unwind-5c87bbe223e6c2a3.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/libobject-d484934062ff9fbb.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/libmemchr-e8dbd5835abcbf43.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/libaddr2line-909ad09329bde2f9.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/libgimli-4d74a3be929697ac.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/librustc_demangle-47cbe1d7f7271ae1.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/libstd_detect-239fd2d25fb32a00.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/libhashbrown-c4a7ce45fb9dec19.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/libminiz_oxide-fa6bc3d9bfb4e402.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/libadler-419f5a82ddd339a3.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/librustc_std_workspace_alloc-7672b378962c11be.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/libunwind-0f9e07f0a032c000.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/libcfg_if-ede7757c356dfb28.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/liblibc-808d56fbc668148a.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/liballoc-784767fe059ad3fe.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/librustc_std_workspace_core-aa31d7ef0556bbe1.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/libcore-81d07df07db18847.rlib" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/libcompiler_builtins-313a510e63006db2.rlib" "-Wl,-Bdynamic" "-lsocket" "-lposix4" "-lpthread" "-lresolv" "-lgcc_s" "-lc" "-lm" "-lrt" "-lpthread" "-lsendfile" "-llgrp" "-L" "/home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib" "-o" "main" "-nodefaultlibs"
  = note: /opt/cross-solaris/gcc730/lib/gcc/sparcv9-sun-solaris2.10/7.3.0/../../../../sparcv9-sun-solaris2.10/bin/ld: warning: -z ignore ignored.
          /home/dlaugt/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/sparcv9-sun-solaris/lib/libstd-fa47c8247d587714.rlib(std-fa47c8247d587714.std.5c42d2c1-cgu.0.rcgu.o): In function `std::sys::unix::fs::link::h3683dfbfbb4995cb':
          /rustc/897e37553bba8b42751c67658967889d11ecd120/library/std/src/sys/unix/fs.rs:1407: undefined reference to `linkat'
          collect2: error: ld returned 1 exit status

  = help: some `extern` functions couldn't be found; some native libraries may need to be installed or have their path specified
  = note: use the `-l` flag to specify native libraries to link
  = note: use the `cargo:rustc-link-lib` directive to specify the native libraries to link with Cargo (see https://doc.rust-lang.org/cargo/reference/build-scripts.html#cargorustc-link-libkindname)

linkat() is not available in the system headers of Solaris 10. The hello word example works fine when I build/use rust with this PR change.

rustbot · 2022-11-28T10:02:12Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

rustbot · 2022-11-28T10:02:14Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

bjorn3 · 2022-11-29T17:49:52Z

library/std/src/sys/unix/fs.rs

@@ -1423,7 +1423,7 @@ pub fn link(original: &Path, link: &Path) -> io::Result<()> {
    run_path_with_cstr(original, |original| {
        run_path_with_cstr(link, |link| {
            cfg_if::cfg_if! {
-                if #[cfg(any(target_os = "vxworks", target_os = "redox", target_os = "android", target_os = "espidf", target_os = "horizon"))] {
+                if #[cfg(any(target_os = "vxworks", target_os = "redox", target_os = "android", target_os = "espidf", target_os = "horizon", target_os = "solaris"))] {


Can you add a comment below why solaris is included here too?

Right, I have added the reason in the comment.

JohnTitor · 2023-01-08T19:49:46Z

Does Solaris 11 or any other version have linkat? If so, I'd have a fallback way like macOS not to change anything for newer Solaris.

the8472 · 2023-03-20T12:55:43Z

See question in previous comment.

@rustbot author

dlaugt · 2023-03-21T07:17:57Z

I haven't a Solaris 11 server. So, I cannot tell if linkat() is available in the system headers of Solaris 11.

JohnTitor · 2023-03-21T08:45:00Z

If we haven't received any reports related to the linkat() availability from 11 (or newer) users, not changing the behavior seems a safe way to me.

…0, available in version 11)

dlaugt · 2023-03-22T10:11:34Z

From Oracle documentation, linkat() is available on Solaris 11:
https://docs.oracle.com/cd/E23824_01/html/821-1463/link-2.html

I've changed the commit to check the presence of linkat() like what is done for MacOS.

ChrisDenton · 2023-04-14T01:37:13Z

The concerns have been addressed and this looks good to me, so...

@bors r+

bors · 2023-04-14T01:37:15Z

📌 Commit f0aa3c6 has been approved by ChrisDenton

It is now in the queue for this repository.

bors · 2023-04-14T05:57:46Z

⌛ Testing commit f0aa3c6 with merge edcbb29...

bors · 2023-04-14T08:08:45Z

☀️ Test successful - checks-actions
Approved by: ChrisDenton
Pushing edcbb29 to master...

rust-timer · 2023-04-14T20:39:42Z

Finished benchmarking commit (edcbb29): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

linkat() not available in the system headers of Solaris 10

1d24374

rustbot assigned joshtriplett Nov 28, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 28, 2022

bjorn3 reviewed Nov 29, 2022

View reviewed changes

Add in the comment that solaris lacks also the 'linkat'

7e21b41

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2023

Check the presence of linkat() on Solaris (not available in version 1…

f0aa3c6

…0, available in version 11)

JohnTitor approved these changes Mar 27, 2023

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 14, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 14, 2023

bors merged commit edcbb29 into rust-lang:master Apr 14, 2023

rustbot added this to the 1.70.0 milestone Apr 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

linkat() not available in the system headers of Solaris 10 #105007

linkat() not available in the system headers of Solaris 10 #105007

dlaugt commented Nov 28, 2022

rustbot commented Nov 28, 2022

rustbot commented Nov 28, 2022

bjorn3 Nov 29, 2022

dlaugt Nov 29, 2022

JohnTitor commented Jan 8, 2023

the8472 commented Mar 20, 2023

dlaugt commented Mar 21, 2023

JohnTitor commented Mar 21, 2023

dlaugt commented Mar 22, 2023

ChrisDenton commented Apr 14, 2023

bors commented Apr 14, 2023

bors commented Apr 14, 2023

bors commented Apr 14, 2023

rust-timer commented Apr 14, 2023

linkat() not available in the system headers of Solaris 10 #105007

linkat() not available in the system headers of Solaris 10 #105007

Conversation

dlaugt commented Nov 28, 2022

rustbot commented Nov 28, 2022

rustbot commented Nov 28, 2022

bjorn3 Nov 29, 2022

Choose a reason for hiding this comment

dlaugt Nov 29, 2022

Choose a reason for hiding this comment

JohnTitor commented Jan 8, 2023

the8472 commented Mar 20, 2023

dlaugt commented Mar 21, 2023

JohnTitor commented Mar 21, 2023

dlaugt commented Mar 22, 2023

ChrisDenton commented Apr 14, 2023

bors commented Apr 14, 2023

bors commented Apr 14, 2023

bors commented Apr 14, 2023

rust-timer commented Apr 14, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles