Enable uv pipe tests on windows #10409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out the pipe names must have special names on windows. Once we have special names, all the tests pass just fine. Closes rust-lang#10386
bors
added a commit
that referenced
this pull request
Nov 11, 2013
Turns out the pipe names must have special names on windows. Once we have special names, all the tests pass just fine. Closes #10386
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 24, 2023
Improve diagnostic of `no_mangle_with_rust_abi` fixes rust-lang#10409 Pending rust-lang/rustfmt#5701 This rewords the message to focus on the error being an implicit ABI, rather than the `Rust` ABI. Also downgrades the suggestion to `MaybeIncorrect` and changes the suggestion span to better highlight the change. --- changelog: None <!-- changelog_checked -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the pipe names must have special names on windows. Once we have
special names, all the tests pass just fine.
Closes #10386