Skip to content

Use full_res instead of expect_full_res #102956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/rustc_resolve/src/late.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1969,7 +1969,7 @@ impl<'a: 'ast, 'b, 'ast> LateResolutionVisitor<'a, 'b, 'ast> {
None
}
})
.map(|res| res.expect_full_res())
.and_then(|res| res.full_res())
.filter(|res| {
// Permit the types that unambiguously always
// result in the same type constructor being used
Expand Down
7 changes: 7 additions & 0 deletions src/test/ui/resolve/issue-102946.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
impl Error for str::Utf8Error {
//~^ ERROR cannot find trait `Error` in this scope
//~| ERROR ambiguous associated type
fn description(&self) {}
}

fn main() {}
26 changes: 26 additions & 0 deletions src/test/ui/resolve/issue-102946.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
error[E0405]: cannot find trait `Error` in this scope
--> $DIR/issue-102946.rs:1:6
|
LL | impl Error for str::Utf8Error {
| ^^^^^ not found in this scope
|
help: consider importing this trait
|
LL | use std::error::Error;
|

error[E0223]: ambiguous associated type
--> $DIR/issue-102946.rs:1:16
|
LL | impl Error for str::Utf8Error {
| ^^^^^^^^^^^^^^
|
help: you are looking for the module in `std`, not the primitive type
|
LL | impl Error for std::str::Utf8Error {
| +++++

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0223, E0405.
For more information about an error, try `rustc --explain E0223`.