Fix infinite recursion in fill_bytes()
#10213
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I get the following error when trying to build, but it doesn't seem related to my fix: |
| @@ -201,4 +201,25 @@ mod test { | |||
| let string2 = r.gen_ascii_str(100); | |||
| assert_eq!(string1, string2); | |||
| } | |||
|
|
|||
| // Fixes #10202 - based on example code for std::rand::Rng::fill_bytes. | |||
|
Can you squash the two commits into 1? (@mention me when you do so, Github doesn't notify when a PR gets updated.) |
Fix the implementation of `std::rand::Rng::fill_bytes()` for `std::rand::reseeding::ReseedingRng` to call the `fill_bytes()` method of the underlying RNG rather than itself, which causes infinite recursion. Fixes #10202.
|
@huonw Should be fixed. |
bors
added a commit
that referenced
this pull request
Nov 1, 2013
…w, r=huonw Fix the implementation of `std::rand::Rng::fill_bytes()` for `std::rand::reseeding::ReseedingRng` to call the `fill_bytes()` method of the underlying RNG rather than itself, which causes infinite recursion. Fixes #10202.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 27, 2023
Improve the changelog update documentation - Make the clippy::version attribute instructions more prominent. - Mention the beta-accepted label. [Rendered](https://github.com/flip1995/rust-clippy/blob/changelog-doc/book/src/development/infrastructure/changelog_update.md) r? `@xFrednet` changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the implementation of
std::rand::Rng::fill_bytes()forstd::rand::reseeding::ReseedingRngto call thefill_bytes()methodof the underlying RNG rather than itself, which causes infinite
recursion.
Fixes #10202.