syntax: remove dead @mut Visitor impl. #10117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(A halloween themed PR: removing dead code. 👻 ) |
Also, move some code only uses in the tests into the test module, and replace some needless @mut ~[] with plain ~[].
bors
added a commit
that referenced
this pull request
Oct 29, 2013
Used nowhere, and these are likely incorrect anyway: self needs to be dereferenced once more otherwise the method calls will be reusing the current impl... bam! Infinite recursion.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 12, 2023
If the author is using todo!(), presumably they intend to use self at some point later, so we don't have a good basis to recommend factoring out to an associated function. Fixes rust-lang#10117. changelog: Don't trigger [`unused_self`] if the method body contains a `todo!()` call
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 12, 2023
unused_self: Don't trigger if the method body contains todo!() If the author is using todo!(), presumably they intend to use self at some point later, so we don't have a good basis to recommend factoring out to an associated function. Fixes rust-lang#10117. --- changelog: Enhancement: [`unused_self`]: No longer lints, if the method body contains a `todo!()` call [rust-lang#10166](rust-lang/rust-clippy#10166) <!-- changelog_checked -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used nowhere, and these are likely incorrect anyway: self needs to be
dereferenced once more otherwise the method calls will be reusing the
current impl... bam! Infinite recursion.