Skip to content

syntax: remove dead @mut Visitor impl. #10117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2013
Merged

Conversation

huonw
Copy link
Member

@huonw huonw commented Oct 28, 2013

Used nowhere, and these are likely incorrect anyway: self needs to be
dereferenced once more otherwise the method calls will be reusing the
current impl... bam! Infinite recursion.

@huonw
Copy link
Member Author

huonw commented Oct 28, 2013

(A halloween themed PR: removing dead code. 👻 )

Also, move some code only uses in the tests into the test module, and
replace some needless @mut ~[] with plain ~[].
bors added a commit that referenced this pull request Oct 29, 2013
Used nowhere, and these are likely incorrect anyway: self needs to be
dereferenced once more otherwise the method calls will be reusing the
current impl... bam! Infinite recursion.
@bors bors closed this Oct 29, 2013
@bors bors merged commit 17b87d2 into rust-lang:master Oct 29, 2013
@huonw huonw deleted the dead-visits branch October 29, 2013 08:36
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 12, 2023
If the author is using todo!(), presumably they intend to use self at
some point later, so we don't have a good basis to recommend factoring
out to an associated function.

Fixes rust-lang#10117.

changelog: Don't trigger [`unused_self`] if the method body contains a `todo!()` call
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 12, 2023
unused_self: Don't trigger if the method body contains todo!()

If the author is using todo!(), presumably they intend to use self at some point later, so we don't have a good basis to recommend factoring out to an associated function.

Fixes rust-lang#10117.

---

changelog: Enhancement: [`unused_self`]: No longer lints, if the method body contains a `todo!()` call
[rust-lang#10166](rust-lang/rust-clippy#10166)
<!-- changelog_checked -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants