Skip to content

Remove the extension traits for Readers/Writers #10079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2013

Conversation

alexcrichton
Copy link
Member

These methods are all excellent candidates for default methods, so there's no need to require extra imports of various traits. Additionally, this was able to remove all the weird underscores after the method names. Yay!

@huonw
Copy link
Member

huonw commented Oct 26, 2013

Couldn't rt::io::extensions now be empty/deleted? (Presumably moving the remaining content to more appropriate places?)

@alexcrichton
Copy link
Member Author

I'm not entirely certain of the fate of rt::io::extensions. Right now it's a small dumping ground for conversion between things, I ended up just dumping the only used std::io functions into it. Some more thought should probably go into the organization of the module before removing it outright.

Do we want to keep the bytes iterator? Do we want to start dumping byte conversions in rt::io? I suppose they kinda belong there b/c all the other conversions are currently done there, but moving the iterator into the module seems a little odd.

@brson
Copy link
Contributor

brson commented Oct 26, 2013

The fate of extensions can be decided later. There's probably no disagreement on this step.

bors added a commit that referenced this pull request Oct 28, 2013
These methods are all excellent candidates for default methods, so there's no need to require extra imports of various traits. Additionally, this was able to remove all the weird underscores after the method names. Yay!
These methods are all excellent candidates for default methods, so there's no
need to require extra imports of various traits.
bors added a commit that referenced this pull request Oct 28, 2013
These methods are all excellent candidates for default methods, so there's no need to require extra imports of various traits. Additionally, this was able to remove all the weird underscores after the method names. Yay!
@bors bors closed this Oct 28, 2013
@bors bors merged commit 72557d8 into rust-lang:master Oct 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants