Skip to content

Visualization for str is broken in the latest Windows SDK #88840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wesleywiser opened this issue Sep 11, 2021 · 1 comment
Open

Visualization for str is broken in the latest Windows SDK #88840

wesleywiser opened this issue Sep 11, 2021 · 1 comment
Assignees
@wesleywiser
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-bug Category: This is a bug. O-windows-msvc Toolchain: MSVC, Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@wesleywiser
Copy link
Member

The update to the latest version of the Windows SDK broke the str visualization.

Related to #88796
@wesleywiser wesleywiser added A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) O-windows-msvc Toolchain: MSVC, Operating system: Windows C-bug Category: This is a bug. labels Sep 11, 2021
@wesleywiser wesleywiser self-assigned this Sep 11, 2021
@wesleywiser wesleywiser mentioned this issue Sep 11, 2021
Merged
wesleywiser added a commit to wesleywiser/rust that referenced this issue Sep 11, 2021
@wesleywiser
Fix debuginfo tests for the latest version of the Windows SDK.
e156df2 
- Cdb now correctly visualizes enums.
- Cdb doesn't render emoji characters in `OSStr` anymore.
- Cdb doesn't always render `str` correctly (rust-lang#88840)
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 20, 2021
@bors
Auto merge of rust-lang#88842 - wesleywiser:fix_dbg_tests_windows_sdk…
e71925a 
…, r=michaelwoerister

Fix debuginfo tests for the latest version of the Windows SDK.

Re-enable the tests that were disabled to fix CI.

Changes:
- Cdb now correctly visualizes enums.
- Cdb doesn't render emoji characters in `OSStr` anymore.
- Cdb doesn't always render `str` correctly (rust-lang#88840)
@michaelwoerister
Copy link
Member

This is very mysterious. It works just fine in other tests like here:

rust/src/test/debuginfo/pretty-std.rs

Lines 88 to 89 in 31d754a

// cdb-command: dx str_slice
// cdb-check:str_slice : "IAMA string slice!" [Type: str]

But it still reproduces with a current 1.66 nightly.

@Noratrieb Noratrieb added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesleywiser wesleywiser

Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-bug Category: This is a bug. O-windows-msvc Toolchain: MSVC, Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wesleywiser @michaelwoerister @Noratrieb