Skip to content

Windows: failing unit tests in libstd\rt\io\file.rs #8810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vadimcn opened this issue Aug 28, 2013 · 0 comments
Closed

Windows: failing unit tests in libstd\rt\io\file.rs #8810

vadimcn opened this issue Aug 28, 2013 · 0 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows

Comments

@vadimcn
Copy link
Contributor

vadimcn commented Aug 28, 2013

file_test_io_smoke_test
file_test_io_non_positional_read
file_test_io_seek_and_tell_smoke_test
file_test_io_seek_and_write
file_test_io_seek_shakedown

These all output task <unnamed> failed at 'Unhandled condition: io_error: {kind: OtherIoError, desc: "unknown error", detail: None}', C:\Rust\src\libstd\condition.rs:43 and crash test runner process.

alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 12, 2013
These tests are being very flaky on the bots, and the reason is that files are
being created and then when attempted to get read they actually don't exist. I'm
not entirely sure why this is happening, but I also don't fully trust the
std::io implemention using @-boxes to close/flush/write files at the right time.

This moves the tests to using std::rt::io which is hopefully more robust and
something that we can actually reason about. Sadly, due to rust-lang#8810, these tests
fail on windows, so they're all ignored on windows right now.
bors added a commit that referenced this issue Sep 13, 2013
These tests are being very flaky on the bots, and the reason is that files are
being created and then when attempted to get read they actually don't exist. I'm
not entirely sure why this is happening, but I also don't fully trust the
std::io implemention using @-boxes to close/flush/write files at the right time.

This moves the tests to using std::rt::io which is hopefully more robust and
something that we can actually reason about. Sadly, due to #8810, these tests
fail on windows, so they're all ignored on windows right now.
klutzy added a commit to klutzy/rust that referenced this issue Sep 16, 2013
They were blocked by rust-lang#8810, but it works now.
@bors bors closed this as completed in d2ce83c Sep 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows
Projects
None yet
Development

No branches or pull requests

1 participant