Skip to content

non_panic_fmt lint suggestion should check what traits are implemented #87999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
m-ou-se opened this issue Aug 13, 2021 · 0 comments · Fixed by #88083
Closed

non_panic_fmt lint suggestion should check what traits are implemented #87999

m-ou-se opened this issue Aug 13, 2021 · 0 comments · Fixed by #88083
Assignees
@m-ou-se
Labels
A-edition-2021 Area: The 2021 edition A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix`

Comments

@m-ou-se
Copy link
Member

m-ou-se commented Aug 13, 2021 •
edited by rylev
Loading

As suggested by @nrc in #87313 (comment), the panic_fmt_lint should suggest "{:?}" if the type implements Debug and not Display.
@m-ou-se m-ou-se added the A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` label Aug 13, 2021
@m-ou-se m-ou-se self-assigned this Aug 13, 2021
@m-ou-se m-ou-se mentioned this issue Aug 13, 2021
Closed
@rylev rylev added the A-edition-2021 Area: The 2021 edition label Aug 13, 2021
@m-ou-se m-ou-se mentioned this issue Aug 16, 2021
Merged
@bors bors closed this as completed in d83da1d Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-ou-se m-ou-se

Labels
A-edition-2021 Area: The 2021 edition A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix`
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve non_fmt_panics suggestion based on trait impls. m-ou-se/rust
2 participants
@m-ou-se @rylev