Cannot name a struct field `new` due to ancient syntax

[huonw]

rusti> struct Foo { new: int }
<anon>:2:14: 2:17 error: obsolete syntax: struct constructor
<anon>:2  struct Foo { new: int } 
                       ^~~
note: structs are now constructed with `MyStruct { foo: val }` syntax. Structs with private fields cannot be created outside of their defining module
<anon>:2:17: 2:18 error: expected `(` but found `:`
<anon>:2  struct Foo { new: int } 
                          ^
rust: task failed at 'explicit failure', /home/huon/rust/src/libsyntax/diagnostic.rs:70

Note that new is a perfectly legal ident:

rusti> let new: uint = 1; new
1

[Aatch]

@kemurphy has a patch in the works that would conflict with these changes, so I'll wait until that lands. Otherwise, I'm happy to clean up the obsolete syntax here.

[Aatch]

Just for some minor amusement, some examples of how old some the obsolete syntax errors are:

let a <- 10;

This suggests changing it to let a = move foo, which is also obsolete... and just a regular parse error (since move isn't a keyword).

fn foo(-a:int) { }

This suggests changing it to fn foo(+a:int) { }, which suggests the same thing 😕.

Anyway, I hope this cheers somebody up 😁

[brson]

Cute.

[minhnhdo]

Hi, I'd love to take on this bug. Could you you give me some pointers on it?

[kemurphy]

@mrordinaire I wouldn't bother until my giant enum overhaul patch lands; one of us will likely hit a merge conflict otherwise that won't be fun to resolve. I'll update this thread when my patch lands.

[minhnhdo]

Cool. I'll wait.

[minhnhdo]

@kemurphy hi, any update on this?

[kemurphy]

@mrordinaire Still in progress, it's a complicated patch and I'm in the middle of a relocation right now so I've got a lot going on.

[minhnhdo]

@kemurphy hi, anything new?

[kemurphy]

@mrordinaire Go ahead and work on it if you want; at this point I'll have to do a big merge anyway and I think it'll be a while before I figure mine out.

[minhnhdo]

@kemurphy could you give me some pointers to solve this?