Skip to content

Maybe change the representation of Registers in std::rt::context #7761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catamorphism opened this issue Jul 13, 2013 · 3 comments
Closed

Maybe change the representation of Registers in std::rt::context #7761

catamorphism opened this issue Jul 13, 2013 · 3 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@catamorphism
Copy link
Contributor

See FIXMEs in contexts.rs (formerly XXXes):

// XXX: Registers is boxed so that it is 16-byte aligned, for storing
// SSE regs.  It would be marginally better not to do this. In C++ we
// use an attribute on a struct.
// XXX: It would be nice to define regs as `~Option<Registers>` since
// the registers are sometimes empty, but the discriminant would
// then misalign the regs again.
@toddaaro
Copy link
Contributor

Would this be a performance gain to do correctly? If so this seems like an easy one and likely something we should do sooner than later.

@sanxiyn
Copy link
Member

sanxiyn commented Jan 3, 2014

Triage. This moved to green::context, otherwise the same.

@thestinger
Copy link
Contributor

#17325 means this is no longer relevant to the standard libraries

flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 7, 2021
@bors
Auto merge of rust-lang#7761 - giraffate:fix_ice_in_inplicit_hasher, …
3311b36 
…r=Manishearth

Fix ICE in `implicit_hasher`

close rust-lang#7712

changelog: Fix ICE in [`implicit_hasher`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sanxiyn @toddaaro @catamorphism @thestinger