-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Resolve needs a better error message for some imports #7584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This interacts especially poorly with mod a {
extern mod extra;
use extra::json;
}
fn main() {} generates
|
Triage bump. Agreed it should be better, but not a release blocker. |
I would like to try to tackle this one by at least providing a better explanation of what is going on. I was able to figure out that it will be necessary to alter |
Same as #8640. |
This I believe was actually closed in 207bfee |
…effen Extend unnecessary_unwrap to look for expect in addition to unwrap changelog: Extend ``[`unnecessary_unwrap`]`` to also check for `Option::expect` and `Result::expect`. Also give code suggestions in some cases. Fixes rust-lang#7581
All imports are relative to the root of the crate, not the current mod. This is counterintuitive and the error messages are rather unhelpful. For example, a
use foo;
should, when resolve fails, look inself
to see if there is afoo
and in the error message suggest usinguse self::foo
.Part of #7379.
The text was updated successfully, but these errors were encountered: