Skip to content

Remove uv I/O from extra. #7251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Jun 20, 2013 · 2 comments
Closed

Remove uv I/O from extra. #7251

brson opened this issue Jun 20, 2013 · 2 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jun 20, 2013

This implementation is deprecated in favor of std::rt::io.

@gavinb
Copy link
Contributor

gavinb commented Jun 22, 2013

I've made a start on this issue. I removed timer.rs, uv.rs, uv_global_loop.rs, uv_iotask.rs, and uv_ll.rs from libextra. Then went about fixing the breakage. The modules net_ip.rs and net_tcp.rs depend on this support, and then net_url.rs and net.rs which depend on them. Should they removed also? Or should they be converted to use the uv support in libstd?

@brson
Copy link
Contributor Author

brson commented Jul 10, 2013

@gavinb I think net_url is the only thing we want to keep. There's an IP type in std::rt::io::ip (or somewhere) that doesn't depend on uv that can replace the libextra IP type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants