Skip to content

In trans::build::GEPi, use a small-vector optimization #6571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catamorphism opened this issue May 18, 2013 · 2 comments
Closed

In trans::build::GEPi, use a small-vector optimization #6571

catamorphism opened this issue May 18, 2013 · 2 comments
Labels
A-codegen Area: Code generation I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@catamorphism
Copy link
Contributor

FIXME says "Use a small-vector optimization to avoid allocations here." To be honest, I'm not even sure if this is referring to optimizing the compiler itself, or the generated code...
@sanxiyn
Copy link
Member

sanxiyn commented Jun 8, 2013

See #7009.

@alexcrichton
Copy link
Member

Closed in f463e69

flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 15, 2021
@bors
Auto merge of rust-lang#6571 - ThibsG:BoxedLocalTrait, r=phansch
ee0598e 
Fix FP for `boxed_local` lint in default trait fn impl

Fix FP on default trait function implementation on `boxed_local` lint.

Maybe I checked too much when looking if `self` is carrying `Self` in its bound type.
I can't find a good test case for this, so it could be too much conservative.
Let me know if you think only detecting `self` parameter is enough.

Fixes: rust-lang#4804

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sanxiyn @alexcrichton @catamorphism