Skip to content

Schouldn't File::sync_all uselibc::fcntl(fd, libc::F_FULLFSYNC) on macos/ios #55920

Closed
@rustonaut

Description

@rustonaut

As far as I know fsync doens't sync data onto disk on macos.
(Depending on kernel & file system it might not do so on linux either).

Which is why sync_data does use fcntl on mac for sync_data
and sync_all implies syncing data, so shouldn't it use fcntl, too?

Metadata

Metadata

Assignees

No one assigned

    Labels

    O-iosOperating system: iOSO-macosOperating system: macOST-libs-apiRelevant to the library API team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions