Skip to content

rustbuild: Rustbuild tests spuriously fail in ~50% cases on Windows #51595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
petrochenkov opened this issue Jun 16, 2018 · 0 comments
Closed

rustbuild: Rustbuild tests spuriously fail in ~50% cases on Windows #51595

petrochenkov opened this issue Jun 16, 2018 · 0 comments
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@petrochenkov
Copy link
Contributor

With errors like this:

thread 'builder::__test::dist_with_targets_and_hosts' panicked at 'fs::create_dir_all(&dst) failed with Access is denied. (os error 5)', bootstrap\dist.rs:103:9

Perhaps rustbuild tests have some filesystem races with each other, or perhaps they need to wait a bit and retry if error happens during directory creation.

cc @Mark-Simulacrum
@petrochenkov petrochenkov added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jun 16, 2018
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Jun 16, 2018
Merged
bors added a commit that referenced this issue Jun 16, 2018
@bors
Auto merge of #51596 - Mark-Simulacrum:bootstrap-racy-tests, r=petroc…
68da15e 
…henkov

Prevent Windows filesystem races in bootstrap tests

Fixes #51595.

This also makes bootstrap tests run near last in `./x.py test` invocations
since they are unlikely to fail.

r? @petrochenkov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petrochenkov