Skip to content

Intra rustdoc links don't work with associated consts #49323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crumblingstatue opened this issue Mar 24, 2018 · 0 comments
Closed

Intra rustdoc links don't work with associated consts #49323

crumblingstatue opened this issue Mar 24, 2018 · 0 comments
Assignees
@GuillaumeGomez
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@crumblingstatue
Copy link
Contributor 

//! We have here [`foo::MYCONST`] and [`Bar::MYCONST`].

pub mod foo {
	pub const MYCONST: u32 = 42;
}

pub struct Bar;

impl Bar {
	pub const MYCONST: u32 = 42;
}

// Test with non-doc usage

pub const C1: u32 = foo::MYCONST;
pub const C2: u32 = Bar::MYCONST;

Renders as:

rustdoc 1.26.0-nightly (c08480fce 2018-03-23)

Ref #43466
@GuillaumeGomez GuillaumeGomez self-assigned this Mar 24, 2018
@GuillaumeGomez GuillaumeGomez mentioned this issue Mar 24, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Mar 27, 2018
@kennytm
Rollup merge of rust-lang#49333 - GuillaumeGomez:link-assoc-const, r=…
68a2e73 
…QuietMisdreavus

Fix impl assoc constant link not working

Fixes rust-lang#49323.

r? @QuietMisdreavus
@pietroalbini pietroalbini added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@crumblingstatue @pietroalbini @GuillaumeGomez