Skip to content

Footnotes don't display properly under CommonMark #45420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
steveklabnik opened this issue Oct 20, 2017 · 4 comments · Fixed by #45421
Closed

Footnotes don't display properly under CommonMark #45420

steveklabnik opened this issue Oct 20, 2017 · 4 comments · Fixed by #45421
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. P-high High priority

Comments

@steveklabnik
Copy link
Member

This footnote generates different HTML under --enable-commonmark and not. Not only does this trigger what's effectively a spurious warning, but it doesn't render correctly either.

cc @QuietMisdreavus @GuillaumeGomez , marking this as p-high
@steveklabnik steveklabnik added P-high High priority A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Oct 20, 2017
This was referenced Oct 20, 2017
Closed
Merged
@ollie27
Copy link
Member

ollie27 commented Oct 20, 2017

This was fixed by pulldown-cmark/pulldown-cmark#21 rustdoc just needs to update its version of pulldown-cmark.

@QuietMisdreavus
Copy link
Member

The thread in that issue says it was released in 0.0.15. According to the lockfile we're pulling in 0.0.14 for rustdoc, but also 0.1.0 for mdbook. I'll see if i can update the dependency for rustdoc and pull it in.

@QuietMisdreavus QuietMisdreavus mentioned this issue Oct 20, 2017
Merged
@QuietMisdreavus
Copy link
Member

#45421 updates Pulldown for rustdoc and fixes this.

@steveklabnik
Copy link
Member Author

I am not sure this actually fixes the warnings, as they use different IDs and such.

I'm testing this locally right now though; expect an update in ~20 minutes

QuietMisdreavus added a commit to QuietMisdreavus/rust that referenced this issue Oct 21, 2017
@QuietMisdreavus
rustdoc: update pulldown renderer
4fdd629 
fixes rust-lang#45420
@TimNN TimNN added the C-bug Category: This is a bug. label Oct 22, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this issue Oct 28, 2017
@frewsxcv
Rollup merge of rust-lang#45421 - QuietMisdreavus:update-pulldown, r=…
e814f75 
…steveklabnik

rustdoc: update pulldown + fix spurious rendering difference around footnotes

fixes rust-lang#45420
kennytm added a commit to kennytm/rust that referenced this issue Oct 28, 2017
@kennytm
Rollup merge of rust-lang#45421 - QuietMisdreavus:update-pulldown, r=…
b644339 
…steveklabnik

rustdoc: update pulldown + fix spurious rendering difference around footnotes

fixes rust-lang#45420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-bug Category: This is a bug. P-high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: update pulldown + fix spurious rendering difference around footnotes QuietMisdreavus/rust
4 participants
@steveklabnik @TimNN @QuietMisdreavus @ollie27