fs::metadata(entry_path).file_type().is_symlink() not work

[xiaozhuai]

let metadata = fs::metadata(file_path).try(stderr);
let filetype = metadata.file_type();
println!("{}", filetype.is_symlink());

It's always false.

[xiaozhuai]

I'm on Linux Mint, the kernel version is 4.4.0-21-generic #37-Ubuntu SMP Mon Apr 18 18:33:37 UTC 2016

[xiaozhuai]

The file system is ext4

[nagisa]

Duplicate of #29302; not a bug.

EDIT: Or rather, is a documentation bug.

[brson]

Update the docs for is_symlink to note that a common source of confusion is to call this on the result of fs::metadata not fs::symlink_metadata.

[CartesianDaemon]

Hi. I'm new to rust, and have been looking through the E-easy tagged bugs for one it would be easy to start with. (Thank you very much for making easy bugs available as on-ramps, it is very very much appreciated.)

I think the appropriate change is in src/libstd/fs.rs in the documentation for is_symlink(). Adding a second line to the description warning that you should use symlink_metadata by default, and changing the example to use fs::symlink_metadata() not fs::metadata().

I have made and tested that change locally. Does that sound right?

[nagisa]

Does that sound right?

Yes.

I would suggest just submitting a PR. Reviewing (commenting on) code directly both spares you the effort describing the changes and us from parsing the description.

[phungleson]

I believe this one is done?

[CartesianDaemon]

Assuming I'm right, yes, I think my commit fixed this particular issue, did everything suggested, and is now merged safely to master.