Skip to content

Allow building benchmarks with rustbuild #37897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bluss opened this issue Nov 20, 2016 · 3 comments
Closed

Allow building benchmarks with rustbuild #37897

bluss opened this issue Nov 20, 2016 · 3 comments
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@bluss
Copy link
Member

bluss commented Nov 20, 2016

Rustbuild should allow building / testing / running benchmarks

I imagine rustbuild's approach will be a lot better for benchmark development and running compared to the old makefiles.

Optional parts:

  • Allow testing different optimization / compiler flags
@bluss bluss added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Nov 20, 2016
@alexcrichton
Copy link
Member

To clarify, by benchmarks, do you mean the one in libraries? (like src/libstd and such).

If that's true then I could totally see this being something like:

./x.py bench src/libstd
./x.py bench src/libcore
# ...

@bluss
Copy link
Member Author

bluss commented Nov 20, 2016

Yes, for example src/libcollectionstest/ contains benchmarks that I want to add to & run.

@alexcrichton
Copy link
Member

Cool! In that case this should be relatively easy to do I think. The steps for this would be:

And I think that's it! After that ./x.py bench should run all the benchmarks we've got for all crates, and specific crates could be selected like ./x.py bench src/libcollections.

bors added a commit that referenced this issue Nov 26, 2016
Add rustbuild command `bench`

Add command bench to rustbuild, so that `./x.py bench <path>` can compile and run benchmarks.

`./x.py bench --stage 1 src/libcollections` and `./x.py bench --stage 1 src/libstd` should both compile well. Just `./x.py bench` runs all benchmarks for the libstd crates.

Fixes #37897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

2 participants