Skip to content

Function items don't pretty-print visibility correctly #3654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Oct 4, 2012 · 1 comment
Closed

Function items don't pretty-print visibility correctly #3654

brson opened this issue Oct 4, 2012 · 1 comment
Labels
A-pretty Area: Pretty printing (including `-Z unpretty`) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone

Comments

@brson
Copy link
Contributor

brson commented Oct 4, 2012

As seen in test/run-pass/reexport-star, pub functions are printed pub pub fn

@cpin
Copy link

cpin commented Nov 5, 2012

On windows at least, this appears to be fixed:

$ rustc.exe ./src/test/run-pass/reexport-star.rs --pretty normal
// FIXME #3654

mod a {
    pub fn f() { }
    pub fn g() { }
}

mod b {
    pub use a::*;
}

fn main() { b::f(); b::g(); }

Edit: also tested on Debian 64bit, same result as above.

@pcwalton pcwalton closed this as completed Dec 4, 2012
RalfJung pushed a commit to RalfJung/rust that referenced this issue Jun 9, 2024
Fix stage in contributing

0 errors now because they were moved by 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pretty Area: Pretty printing (including `-Z unpretty`) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

3 participants