Skip to content

Print total time for a build invocation #34600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexcrichton opened this issue Jul 1, 2016 · 2 comments
Closed

Print total time for a build invocation #34600

alexcrichton opened this issue Jul 1, 2016 · 2 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@alexcrichton
Copy link
Member

I've found it nifty when building Servo that the total time for the build is printed at the end, and I think we may want to do so as well! Let's modify rustbuild (src/bootstrap) to print how long the entire program takes.

Depending on how easy it is we may want to modify the python script (src/bootstrap/bootstrap.py) as that's the wrapper for everything, but if it's too much effort then let's just modify src/bootstrap/main.rs and assume the python bits are fast.

Should be a pretty easy bug to knock out and I'd be willing to help out anyone interested!
@alexcrichton alexcrichton added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 1, 2016
@nikhilshagri
Copy link
Contributor

I'll try my hand at this one.

@alexcrichton
Copy link
Member Author

All yours @cynicaldevil!

@nikhilshagri nikhilshagri mentioned this issue Jul 2, 2016
Merged
bors added a commit that referenced this issue Jul 3, 2016
@bors
Auto merge of #34614 - cynicaldevil:build-time, r=alexcrichton
da099c2 
Build: Shows total time taken to build the compiler

Fixes #34600
Prints the total time taken to build rustc by executing `src/bootstrap/bootstrap.py`; also includes time taken to download `stage0` compiler and deps.

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @nikhilshagri