Skip to content

14.4, "Polymorphic Traits", refers to "the 'of' clause", but there's no 'of' #3375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jimblandy opened this issue Sep 4, 2012 · 2 comments
Closed
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone

Comments

@jimblandy
Copy link
Contributor

para 2. says, "the 'of' clause refers to a type, rather than defining one."

I can't tell what an "'of' clause" is; there's no appearance of the token 'of' in the code.

The phrase "'of' clause" also occurs in 14.7, "Traits-less implementations".

@burg
Copy link

burg commented Sep 5, 2012

of was part of the old syntax for trait implementation declarations. This should be a fairly simple fix.

burg: 'impl foo of bar' got changed to 'impl foo: bar', right?
nmatsakis: burg: not...exactly
nmatsakis: more like `impl of foo for bar` got changed to `impl bar: foo`
nmatsakis: that is, `impl rcvr_type: trait_type`

@lkuper
Copy link
Contributor

lkuper commented Sep 6, 2012

impl of Trait for Type changed to impl Type: Trait in this heroic commit by @brson a month ago.

Back when traits were called ifaces, there was such a thing as an interface-less implementation that omitted the of Trait part; that's the part that used to be known as an "of clause".

We now have trait-less implementations; the text in that section also needs to be edited to remove a mention of of.

I think that "—the of clause refers to a type, rather than defining one." should just be nixed.

@ghost ghost assigned catamorphism Sep 6, 2012
RalfJung pushed a commit to RalfJung/rust that referenced this issue Mar 15, 2024
jaisnan pushed a commit to jaisnan/rust-dev that referenced this issue Jul 29, 2024
This enables use of `|result|` when verifying the standard library.
jaisnan pushed a commit to jaisnan/rust-dev that referenced this issue Jul 29, 2024
… into kani_core) (rust-lang#3376)

This adds the commit from rust-lang#3375 to features/verify-rust-std.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

4 participants