Skip to content

Fix shootout benchmarks #2913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Jul 13, 2012 · 4 comments · Fixed by #10145
Closed

Fix shootout benchmarks #2913

brson opened this issue Jul 13, 2012 · 4 comments · Fixed by #10145
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jul 13, 2012

Several of them do not report the correct results, per Isaac Gouy:

I saw that there'd been changes to mozilla/rust/src/test/bench so I took a look and ran the programs with Rust 0.3

There are a few trivial errors --

1) binarytrees prints "long lived trees of depth" instead of "long lived tree of depth"


2) chameneosredux -- the whitespace printed by show_number should be the same as printed by show_color

See the attached file.

3) spectralnorm prints an extra \n

4) threadring prints an extra \n


and less trivial errors


5) fasta -- strangely, output stops half-way through line 169 -- with another 8166 lines still to do.

6) the latest binarytrees fails with input N=20 on a 4GB machine.


stretch tree of depth 21     check: -1
2097152     trees of depth 4     check: -2097152
524288     trees of depth 6     check: -524288

@catamorphism
Copy link
Contributor

Confirmed that (1) and (5), at least, are still issues. I'm not sure I understand (2), (3), and (4).

@Thiez
Copy link
Contributor

Thiez commented Jun 16, 2013

The spectralnorm problem was solved in 9738c2a by @pcwalton

@Thiez
Copy link
Contributor

Thiez commented Jun 24, 2013

This shouldn't be closed; as @brson pointed out at #7193, the last problem (binarytrees) is not yet fixed.

@huonw huonw reopened this Jun 24, 2013
@toddaaro
Copy link
Contributor

Visiting for triage. This should be dealt with, but it should be considered low priority.

bors added a commit that referenced this issue Oct 29, 2013
The old version didn't follow shootout's directives: no memory were
deallocated.  At the same time, parallelisation of the computation.

fix #2913
@bors bors closed this as completed in 4ca32e1 Oct 30, 2013
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
Changes required due to:
- rust-lang/rust@99ac405b96 Move MetadataLoader{,Dyn} to rustc_metadata.
- rust-lang/rust@c997c6d822 Add more information to stable Instance
- rust-lang#116915

This also fixes an issue in the `simd_shuffle` implementation that was exposed by the update.

Resolves rust-lang#2911

---------

Co-authored-by: Celina G. Val <[email protected]>
Co-authored-by: Adrian Palacios <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
5 participants