Skip to content

cfail tests do not check for unexpected errors on windows #27952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Diggsey opened this issue Aug 23, 2015 · 0 comments
Closed

cfail tests do not check for unexpected errors on windows #27952

Diggsey opened this issue Aug 23, 2015 · 0 comments
Labels
O-windows Operating system: Windows

Comments

@Diggsey
Copy link
Contributor

Diggsey commented Aug 23, 2015

Currently the cfail test runner works by parsing rustc's stderr, and scanning the output for errors/warnings. It uses the pattern <filename>:<line>:<col> [error|warning] to check whether a line of output is an unexpected error.

This never succeeds on windows, because absolute paths start with a drive letter + colon, eg. "C:", and the colon breaks the pattern.

The result is that any number of additional errors are allowed to be generated without causing the cfail tests to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows Operating system: Windows
Projects
None yet
Development

No branches or pull requests

2 participants