Skip to content

Consider using InitializeCriticalSectionEx on Vista and higher #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eholk opened this issue Jul 2, 2012 · 2 comments
Closed

Consider using InitializeCriticalSectionEx on Vista and higher #2778

eholk opened this issue Jul 2, 2012 · 2 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows Operating system: Windows

Comments

@eholk
Copy link
Contributor

eholk commented Jul 2, 2012

Per a TODO (soon to be a FIXME) in lock_and_signal.cpp:

    // TODO? Consider checking GetProcAddress("InitializeCriticalSectionEx")
    // so Windows >= Vista we can use CRITICAL_SECTION_NO_DEBUG_INFO to avoid
    // allocating CRITICAL_SECTION debug info that is never released. See:
    // http://stackoverflow.com/questions/804848/
    //        critical-sections-leaking-memory-on-vista-win2008#889853
@bstrie
Copy link
Contributor

bstrie commented Apr 26, 2013

The FIXME in question references #2893, which has been closed. Wondering if this should be closed as well.

@pcwalton
Copy link
Contributor

Closing this because this should be done in Rust.

celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-enhancement Category: An issue proposing an enhancement or a PR with one. O-windows Operating system: Windows
Projects
None yet
Development

No branches or pull requests

3 participants