Skip to content

libstd: Div is not implemented for Wrapping #26867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crumblingstatue opened this issue Jul 7, 2015 · 5 comments
Closed

libstd: Div is not implemented for Wrapping #26867

crumblingstatue opened this issue Jul 7, 2015 · 5 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@crumblingstatue
Copy link
Contributor

Is this intentional or has this been an oversight?
@steveklabnik
Copy link
Member

/cc @rust-lang/libs

@Gankra
Copy link
Contributor

Gankra commented Jul 7, 2015

Should be implemented.

@alexcrichton
Copy link
Member

Yeah this is fine to implement, but we tend to not keep tracking issues open for minor things like this, so closing. Feel free to send a PR though!

@crumblingstatue
Copy link
Contributor Author

Right now I don't plan on hacking on the Rust codebase, so I won't implement this myself.
Won't not tracking this issue make it easy to forget implementing this?
Or is it not beneficial enough to implement that forgetting it is fine?

@huonw huonw added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Jul 7, 2015
@huonw
Copy link
Member

huonw commented Jul 7, 2015

Reopening, as a bug.

Tagging as E-easy, since this should just be calling the normal / operator (we can't avoid checking for 0 and -1, since they're actually undefined behaviour).

@huonw huonw reopened this Jul 7, 2015
@mvdnes mvdnes mentioned this issue Jul 8, 2015
Merged
bors pushed a commit that referenced this issue Jul 9, 2015
@mvdnes
Implement Div for Wrapping<T>
e333a57 
Resolves #26867
bors added a commit that referenced this issue Jul 9, 2015
@bors
Auto merge of #26885 - mvdnes:wrapping_div, r=alexcrichton
9c3ba76 
Resolves #26867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@steveklabnik @alexcrichton @Gankra @huonw @crumblingstatue