Skip to content

1.0.0 lacks share/doc/rust/html/error-index.html #26240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcast opened this issue Jun 12, 2015 · 4 comments
Closed

1.0.0 lacks share/doc/rust/html/error-index.html #26240

mcast opened this issue Jun 12, 2015 · 4 comments

Comments

@mcast
Copy link
Contributor

mcast commented Jun 12, 2015

After install from rust-1.0.0-x86_64-apple-darwin.tar.gz, the link in share/doc/rust/html/index.html#the-error-index to share/doc/rust/html/error-index.html is 404. (This doesn't trouble me, I'm still poking around.)

404 because it is absent rather than renamed - by grep -r "Rust Compiler Error Index" rust-1.0.0/.

I found src/error-index-generator/main.rs but haven't looked at where the ends don't meet. I'm happy to carry on digging later...

@mcast
Copy link
Contributor Author

mcast commented Jun 12, 2015

Found something: deaa117 removes error-index from DOC_TARGETS := trpl style error-index in mk/docs.mk due to #25705.

@steveklabnik
Copy link
Member

That patch landed way after 1.0, so it shouldn't have affected this.

@mcast
Copy link
Contributor Author

mcast commented Jun 12, 2015

Yes... 98fef7b is where the href arrives on stable. It is the same as part of 6faa8d6, to the second, but the latter also touches src/librustc/diagnostics.rs.

src/error-index-generator/main.rs is added only in 1174114 and that isn't in stable. git log --name-only stable |grep error-index is nul.

So what to do?

  • Remove that section of src/doc/index.md from stable
  • Run the tool now (compile from master, run on stable?), stash the resulting html in the stable tree

The one on master isn't compiling for me just now. Maybe it can be my first dunking in rust.

$ DYLD_LIBRARY_PATH=~/Applications/rust-1.0.0/lib rustc -o error-index-generator src/error-index-generator/main.rs 
src/error-index-generator/main.rs:23:37: 23:53 error: unresolved import `syntax::diagnostics::metadata::get_metadata_dir`. Could not find `metadata` in `syntax::diagnostics`
src/error-index-generator/main.rs:23 use syntax::diagnostics::metadata::{get_metadata_dir, ErrorMetadataMap};
                                                                         ^~~~~~~~~~~~~~~~
src/error-index-generator/main.rs:23:55: 23:71 error: unresolved import `syntax::diagnostics::metadata::ErrorMetadataMap`. Could not find `metadata` in `syntax::diagnostics`
src/error-index-generator/main.rs:23 use syntax::diagnostics::metadata::{get_metadata_dir, ErrorMetadataMap};
                                                                                           ^~~~~~~~~~~~~~~~
error: aborting due to 2 previous errors

and yes, some kind of installer/dyld problem too.

@alexcrichton
Copy link
Member

Unfortunately the error-index-generator uses unstable features right now (links to libsyntax as you've seen), which means that it's not generally going to work if you compile it out-of-tree (due to libsyntax changing rapidly over time).

I think that generation of this is currently disabled as well due to various implementation issues in the previous version, so I'm going to close this in favor of #26009.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants