Skip to content

rustc --version reported date is confusing #21957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Feb 5, 2015 · 5 comments
Closed

rustc --version reported date is confusing #21957

brson opened this issue Feb 5, 2015 · 5 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Feb 5, 2015

I've heard several people express concern that their nightly was not up to date because the date reported by rustc --version is old. This date is the commit date, not the build date.
@brson brson added the A-build label Feb 5, 2015
@brson
Copy link
Contributor Author

brson commented Feb 5, 2015

On this subject @eddyb said

22:31 < eddyb_> brson: would be nice if it gave build info and source (git) info
22:31 < eddyb_> but clearly distinguished from each-other

to which @blaenk responded

22:35 < blaenk> yeah that'd be cool

@brson brson added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Feb 5, 2015
@brson
Copy link
Contributor Author

brson commented Feb 5, 2015

Easy to implement. Just need to decide what to change.

@huonw
Copy link
Member

huonw commented Feb 5, 2015

FWIW, even the (start of) build date may be confusing, since the nightly builds take many hours.

@brson
Copy link
Contributor Author

brson commented Feb 6, 2015

Should update how rustdoc and cargo report their version at the same time.

brson added a commit to brson/rust that referenced this issue Feb 13, 2015
@brson
Add the build date to the reported version. rust-lang#21957
effad62 
rustc --version says

```
rustc 1.0.0-dev (d0e82a6 2015-02-05) (built 2015-02-11)
```
@iKevinY
Copy link
Contributor

iKevinY commented Feb 16, 2015

Looks like this can be closed since #22201 has been rolled up.

@iKevinY iKevinY mentioned this issue Feb 27, 2015
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Feb 28, 2015
@Manishearth
Rollup merge of rust-lang#22866 - iKevinY:version-output-doc-fix, r=M…
fcd1c36 
…anishearth

 The format of `rustc --version` was changed in rust-lang#21957; this PR updates TRPL accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @brson @huonw @iKevinY