Skip to content

compile-test fails to detect extranous errors on windows #21228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oli-obk opened this issue Jan 16, 2015 · 1 comment
Closed

compile-test fails to detect extranous errors on windows #21228

oli-obk opened this issue Jan 16, 2015 · 1 comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Jan 16, 2015

the problem is in this function: https://github.com/rust-lang/rust/blob/master/src/compiletest/runtest.rs#L1009

since windows-paths contain a colon, finding the error/warning through counting colons is not the way to go.

i need this fixed, so i'm fixing it.
should i use regex or simply check if the line starts with the testfile-name, and skip those chars before counting colons?

@kmcallister kmcallister added A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows labels Jan 16, 2015
@alexcrichton
Copy link
Member

I believe this was fixed in #27974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows Operating system: Windows
Projects
None yet
Development

No branches or pull requests

3 participants