make install is failing

[chris-morgan]

$ make install
…
rustdoc: doc/rustc_trans/index.html
/home/chris/rust/src/librustc_trans/lib.rs:25:40: 25:46 warning: feature has been added to Rust, directive not necessary
/home/chris/rust/src/librustc_trans/lib.rs:25 #![feature(default_type_params, globs, if_let, import_shadowing, macro_rules, phase, quote)]
                                                                                     ^~~~~~
<stdin>:5:2: 5:3 error: unknown start of token: \\
<stdin>:5  \   /
           ^
task '<main>' panicked at 'Box<Any>', /home/chris/rust/src/libsyntax/diagnostic.rs:99
/home/chris/rust/mk/docs.mk:287: recipe for target 'doc/rustc_trans/index.html' failed
make[1]: *** [doc/rustc_trans/index.html] Error 101
make[1]: Leaving directory '/home/chris/rust'
/home/chris/rust/mk/install.mk:22: recipe for target 'install' failed
make: *** [install] Error 2

We seem to break make install completely once every few months, because buildbot doesn’t actually try doing make install…

[csouth3]

+1. I can confirm I'm getting the same error.

[nodakai]

https://github.com/rust-lang/rust/blob/master/src/librustc/metadata/loader.rs#L186

//! ## Loading transitive dependencies
//!
//! Dealing with same-named-but-distinct crates is not just a local problem, but
//! one that also needs to be dealt with for transitive dependencies. Note that
//! in the letter above `--extern` flags only apply to the *local* set of
//! dependencies, not the upstream transitive dependencies. Consider this
//! dependency graph:
//!
//! ```ignore
//! A.1   A.2
//! |     |
//! |     |
//! B     C
//!  \   /
//!   \ /
//!    D
//! ```

There are two similar figures in librustc/middle/infer/doc.rs

[2bdkid]

Can confirm also, getting same error.

[Kintaro]

Same here. Buildbot should include a make install step to capture stuff like that.

[Passw]

+1.

[nodakai]

git log src/librustdoc showed 096a286 was the last commit which directly modified src/librustdoc. But that version didn't suffer from this problem. So I tried git bisect. git bisect start master 096a286 followed by git bisect run ./bs.sh (basically rm -rf doc, configure and then make -j8 compiler-docs) told me 8ba5605 was the first bad commit.

@steveklabnik Can you look into this issue? As I already posted, the error seems to be because ignore cannot contain an arbitrary text which resembles to an escaped character.

[steveklabnik]

Ugh, yes, some of these should be annotated text.

[steveklabnik]

Okay, make install fails for me. It seems like the blocsk are properly annotated text, though :/

[2bdkid]

Has this been fixed yet? I'm still getting the same error. Should a "git pull" pull in the updates or is there other stuff I need to do?

[Gankra]

#19705 needs to be merged first.