Skip to content

rustup.sh / install.sh don't install license documents and thus violate several open source licenses #19376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nodakai opened this issue Nov 28, 2014 · 2 comments

Comments

@nodakai
Copy link
Contributor

nodakai commented Nov 28, 2014

$ rust-nightly-x86_64-unknown-linux-gnu/install.sh --prefix=/tmp/xyz
install: looking for install programs 
...
install: /tmp/xyz/lib/libtime-4e7c5e5c.so
install: /tmp/xyz/lib/librustdoc-4e7c5e5c.so
install: /tmp/xyz/share/man/man1/rustc.1
install: /tmp/xyz/share/man/man1/rustdoc.1
install: /tmp/xyz/bin/rust-lldb       
install: /tmp/xyz/bin/rustdoc         
install: /tmp/xyz/bin/rustc           
rust-nightly-x86_64-unknown-linux-gnu/install.sh: 479: rust-nightly-x86_64-unknown-linux-gnu/install.sh: ldconfig: not found
install: WARNING: failed to run ldconfig.
install: WARNING: this may happen when not installing as root and may be fine
install: verifying installed binaries are executable

    Note: please ensure '/tmp/xyz/lib' is added to LD_LIBRARY_PATH

    Rust is ready to roll.            
$ grep -nHr Illinois rust-nightly-x86_64-unknown-linux-gnu/
rust-nightly-x86_64-unknown-linux-gnu/COPYRIGHT:143:    Copyright (c) 2003-2013 University of Illinois at
rust-nightly-x86_64-unknown-linux-gnu/COPYRIGHT:150:        University of Illinois at Urbana-Champaign
rust-nightly-x86_64-unknown-linux-gnu/COPYRIGHT:175:          Illinois at Urbana-Champaign, nor the names of its
rust-nightly-x86_64-unknown-linux-gnu/COPYRIGHT:206:        University of Illinois at Urbana-Champaign
rust-nightly-x86_64-unknown-linux-gnu/COPYRIGHT:231:          Illinois at Urbana-Champaign, nor the names of its
$ grep -nHr Illinois /tmp/xyz   

All of the code in LLVM is available under the University of Illinois/NCSA Open Source License, which boils down to this:

...

  • You must retain the copyright notice if you redistribute LLVM.

I'm actually considering to add a new option --license to rustc and rustdoc so that they can always reproduce the content of the COPYING file. How does it sound?

@steveklabnik
Copy link
Member

This is sort of a dup of #17690

@nodakai
Copy link
Contributor Author

nodakai commented Nov 28, 2014

@steveklabnik Exactly! How did I overlook it???

@nodakai nodakai closed this as completed Nov 28, 2014
lnicola pushed a commit to lnicola/rust that referenced this issue Apr 28, 2025
minor: Remove unnecessary allocations in `function::params_display`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants