Skip to content

On non-compiletest tests, only use a single test task when valgrinding #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Mar 4, 2012 · 6 comments
Closed
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. I-compiletime Issue: Problems and improvements with respect to compile times. P-low Low priority

Comments

@brson
Copy link
Contributor

brson commented Mar 4, 2012

For test runners that don't spawn subprocesses for every test (rustc, core, std, rustdoc), trying to run tests in parallel under valgrind just makes the entire test run slower. The build should detect when we are valgrinding and pass a flag (that doesn't exist yet) to the test runner telling it to use only 1 test task at a time.

I've noticed that the linux1 bot is taking an absurd amount of time to run coretest. This might help.

@ghost ghost assigned brson Mar 8, 2012
@emberian
Copy link
Member

Triage bump; still relevant.

@brson
Copy link
Contributor Author

brson commented Jul 19, 2013

There's a function exported from the runtime to check whether we're running under valgrind that could be used for this.

@thestinger
Copy link
Contributor

@brson: did we ever do this?

@brson
Copy link
Contributor Author

brson commented Oct 11, 2013

@thestinger no

@catamorphism
Copy link
Contributor

Low, no milestone

reedlepee123 added a commit to reedlepee123/rust that referenced this issue Nov 3, 2013
reedlepee123 added a commit to reedlepee123/rust that referenced this issue Nov 3, 2013
reedlepee123 added a commit to reedlepee123/rust that referenced this issue Nov 3, 2013
@alexcrichton
Copy link
Member

Closing, this is done for all pieces of infrastructure using libtest: https://github.com/mozilla/rust/blob/master/src/libstd/rt/util.rs#L49-L72

celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. I-compiletime Issue: Problems and improvements with respect to compile times. P-low Low priority
Projects
None yet
Development

No branches or pull requests

5 participants