Skip to content

Unify formatting floats and f{32,64}::to_str_digits #15432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
erickt opened this issue Jul 4, 2014 · 2 comments
Closed

Unify formatting floats and f{32,64}::to_str_digits #15432

erickt opened this issue Jul 4, 2014 · 2 comments

Comments

@erickt
Copy link
Contributor

erickt commented Jul 4, 2014

cc @alexcrichton. It looks like we have a lot of duplicated code with libcore/fmt/float.rs and std::num::strconv::float_to_str_bytes_common. Can this code be merged?
@alexcrichton
Copy link
Member

I'd love to remove the libstd version! I think that it did a thing or two that the libcore version didn't do (hence the duplication), but those bits could probably just be removed.

@alexcrichton alexcrichton reopened this Jul 5, 2014
@steveklabnik
Copy link
Member

I'm not sure how this has gottne shuffled, but to_str_digits nor most of these modules still exist. Let me know if this refactor is still worthwhile!

bors added a commit to rust-lang-ci/rust that referenced this issue Nov 13, 2023
@bors
Auto merge of rust-lang#15432 - alibektas:deunwrap/inline_call, r=Vey…
2ededa2 
…kril

minor : Deunwrap inline call

rust-lang#15398 subtask 4. There is still one instance of unwrap, which I found pretty hard to change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @alexcrichton @erickt