Skip to content

manual: header links are wrong #15333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
steveklabnik opened this issue Jul 2, 2014 · 4 comments
Closed

manual: header links are wrong #15333

steveklabnik opened this issue Jul 2, 2014 · 4 comments

Comments

@steveklabnik
Copy link
Member

links to http://doc.rust-lang.org/rust.html#lvalues,-rvalues-and-temporaries within the text are wrong, because there's a comma in the name now.

Making a note of this because I don't have time to fix it immediately.
@mdinger
Copy link
Contributor

mdinger commented Jul 2, 2014

Untested but should fix it.
mdinger@4afe310

Did a text search over the entire tree for #lvalues-rvalues-and-temporaries. Should be all the links.

@mdinger mdinger mentioned this issue Jul 3, 2014
Merged
bors added a commit that referenced this issue Jul 4, 2014
@bors
auto merge of #15378 : mdinger/rust/Issue_15333, r=alexcrichton
5012b85 
Here's the issue: #15333

Tested it. It works. FYI, in case anyone doesn't know: keyboard shortcut `'` restricts text search to only links on Firefox allowing this to be checked easily.
@mdinger
Copy link
Contributor

mdinger commented Jul 4, 2014

Fix just merged. Probably safe to close this.

@steveklabnik
Copy link
Member Author

Thank you so much for the fix!

@mdinger
Copy link
Contributor

mdinger commented Jul 9, 2014

Glad to help.

bors added a commit to rust-lang-ci/rust that referenced this issue Aug 7, 2023
@bors
Auto merge of rust-lang#15333 - davidbarsky:davidbarsky/downgrade-vsc…
b64e5b3 
…ode-to-1.75, r=lnicola

vscode: change minimum VS Code version to 1.75 from 1.78

I previously mentioned [in a comment](rust-lang/rust-analyzer#15265 (comment)) that folks at my employer are on 1.78, but I was incorrect: people are on 1.75. I know this is outside the standard version support policy, but I haven't seen any of the new features in VS Code be used in rust-analyzer. The most applicable feature in those three versions of VS Code that I can find [is lazily resolving code actions](https://code.visualstudio.com/updates/v1_78#_resolve-code-action-commands-in-resolvecodeaction), but it doesn't seem like rust-analyzer is making use of that feature.

(I'll be posting a PR that adds support for `$saved_file` within the next day, so feel free to bump the minimum VS Code version back to 1.78 if/when that PR lands. This just makes vendoring the _actual_ change I'm interested in a little bit easier.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steveklabnik @mdinger