Skip to content

Rename Share to e.g. Threadsafe #14828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Jun 11, 2014 · 7 comments
Closed

Rename Share to e.g. Threadsafe #14828

brson opened this issue Jun 11, 2014 · 7 comments

Comments

@brson
Copy link
Contributor

brson commented Jun 11, 2014

We want to use the word 'share' to refer to & ('shared reference'). This 'sharing' refers to both local and multithreaded sharing since &T: Threadsafe types can be shared across threads. This renaming requires the current Share trait to be renamed.

@michaelwoerister
Copy link
Member

👍

@Kimundi
Copy link
Member

Kimundi commented Jun 12, 2014

Well, it's at least self documenting :)

@pnkfelix
Copy link
Member

This needs to follow the RFC process: https://github.com/rust-lang/rfcs/

@brson
Copy link
Contributor Author

brson commented Jun 13, 2014

This issue was supposed to be a reminder that we need to create an rfc to complete this issue. How else am I supposed to rember wtf we need to do if I can't post it to the issue tracker (frustrated)?

@brson brson reopened this Jun 13, 2014
@brson
Copy link
Contributor Author

brson commented Jun 13, 2014

...

@pnkfelix
Copy link
Member

@brson In response to your frustration: I would imagine that sort of "to-do" issue would still be better suited filed in the RFC repository, not the rust repository.

All I was doing was holding you to the same standard to which I would hold any community member.

@pnkfelix
Copy link
Member

(having said that, if you really do want an tracking issue on the rust repository for such to-do items, then in that case I think it would suffice to just explicitly say that the issue is a to-do marker, i.e. that you recognize that it is meant to lead to the filing of an RFC later.)

bors added a commit to rust-lang-ci/rust that referenced this issue Jun 5, 2023
…e, r=Veykril

fix: process `macro_use` prelude in semantic scope resolver

Fixes rust-lang#14826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants