-
Notifications
You must be signed in to change notification settings - Fork 13.3k
relicense shootout-meteor.rs to the shootout licence #14420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
For what it’s worth, I agree to have re-licensed under BSD any contribution I made under MIT, including any contribution to https://github.com/mozilla/rust |
Thanks for undertaking this @TeXitoi. Some thoughts on the process here:
Finally, please email me the written statement from each, and I will file them somewhere. Please don't r+ this until I'm satisfied we're covered. |
@brson thanks for responding. I have some questions:
|
awww my contribution was removed? Nutz. :) Must do more in the future... @TeXitoi I don't have an opinion either way with respect to the licence. There are people far more involved than I (like yourself) that should make the decision. :) |
Updated OP:
|
I hereby agree to change the license of shootout benchmark source files to the proposed one and this should be considered as good as a written permission. |
I also agree to change the license of shootout benchmark source files to the one proposed here. |
Updated contributors' status according to comments. @brson Any answers to my questions? |
@TeXitoi moco employees tend to have "@mozilla.com" addresses. @alexcrichton, @pcwalton, @SimonSapin are moco. Most everybody on your list is a long-standing contributor that will agree, but we still do need to get them to agree. I will put some time into this tomorrow to make sure I'm confident we've got a reasonable documentation trail, then I'll merge. I think comments on GitHub are good enough, but mostly because this is such a minor licensing issue that it hardly matters. If we were being more careful we would craft the exact statement we want them to say and tell them to copy and paste it into an email. A statement like the following is probably best: "I agree to relicense any previous contributions to http://github.com/mozilla/rust according to the following terms: [complete license text]" |
@TeXitoi I sent an email to the stragglers. |
Ha, didn't realize this was not a PR until just now. |
You might want to check how you're checking git blame? I'm unlisted for both trivial & non-trivial; so you might want to double-check you haven't missed anyone else. (for reference, I recently rewrote the bulk of mandlebrot) |
@brson aha, mybad! |
@brson I'm on weekend, I'll propose a PR next week. |
part of rust-lang#14248, fix rust-lang#14420 Removed @richo's contribution (outdated comment) Quoting @brson: let's move forward with this one. The only statement I'm missing is @richo's and it sounds like his was a minor patch.
…t-lang#14420) Commit efe3fe9 removed the ability for `single_match` and `single_match_else` to trigger if comments were present outside of the arms, as those comments would be lost while rewriting the `match` expression. This reinstates the lint, but prevents the suggestion from being applied automatically in the presence of comments by using the `MaybeIncorrect` applicability. Also, a note is added to the lint message to warn the user about the need to preserve the comments if acting upon the suggestion. changelog: [`single_match`, `single_match_else`]: reinstate lint when comments are inside the `match` but do not autofix the code Fix rust-lang#14418
See #14248
I propose to change the license of
shootout-meteor.rs
as this is the most recent written bench.The proposed patch (not a PR as I can't distribute the file with the new license without the authorisation of the copyright owners) is
First, I must say that, IMHO, the shootout license is compatible to the MIT license in the philosophy, and thus, relicensing to this license may be possible without any agreement (but I am not a lawyer).
I propose to list all the contributors of this file according to their contribution, and ask them to agree to change the license of every shootout benchmark (
src/test/bench/shootout*.rs
) in the comments of this issue. I'll update the list according to their response.Non trivial contributors:
Contributors appearing in git blame that are trivial (trivial update due to language changes)
'self
lifetime illegal): OKswap
): OK~[T]
removing): MoCo employeeStrBuff
toString
(only apear in a comment, the comment should be updated as String is not used): waiting for responseprintln
from prelude): OKContributors with removed contributions (acceptation of the license change is not necessary IMHO):
from_utf8_owned
remove): optionalrev()
modifications): OKfrom_utf8_owned_opt()
): OKvec_ng
remove): optionalFinally, I'd like that @brson or any core developer validates the process, and say if trivial changes should be taken into account for that.
When the license change will be accepted, I'll send a PR.
The text was updated successfully, but these errors were encountered: