-
Notifications
You must be signed in to change notification settings - Fork 13.4k
syntax::parse::attr
implementation disagrees with BNF in manual
#13825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I believe the manual is correct in this case, that looks like it should be a valid attribute. |
But, which is the behaviour we want? |
Yes, I could imagine either scheme becoming blessed as the preferred style, so I feel this needs more discussion if it hasn't already been decided. Either way, there will need to be a test to preserve the preferred style in the future. |
Nominating. |
Not a 1.0 milestone issue, Asssigning P-low. |
IMO, we should not accept a comma in attributes. We never used that feature, I've long wanted to remove it, and didn't realize that it was broken. |
Attribute grammar in reference manual allowed `#[foo, bar]`, which does not match parser behavior. Also rename nonterminals to match parser code. Fix #13825.
…back, r=Veykril feat: Add `unqualify_method_call` assist ...which is the inverse of `qualify_method_call` assist.  Optional future work: - import the trait if needed - remove excess references when auto-ref is possible
According to the manual, multiple comma-separated attributes may be specified within a single pair of square brackets. The parser does not do this at present (02ba8e2). Which one is correct?
Use case:
The text was updated successfully, but these errors were encountered: