-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Write (at least) type signatures of placeholder functions in docs #13423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Prevents errors
|
Someone reading the docs won't know what the types of various things are, so this adds them in a few meaningful places to help with comprehension. cc rust-lang#13423.
Add more type signatures to the docs; tweak a few of them. Someone reading the docs won't know what the types of various things are, so this adds them in a few meaningful places to help with comprehension. cc #13423.
Example extra (HTTP Server): https://gist.github.com/IrvMG/10617371 |
@huonw given that your PR in this specific case got merged, is this still valid? I mean, there may be other cases, but how will we know when this issue is done? |
Maybe we could just do a quick pass over the docs to try to remove any remaining current instances (e.g. |
👍 |
Whew! |
I searched for times when we were hiding functions with # in the documentation, and fixed them to not use it unless neccesary. I also made random improvements whenever I changed something. For example, I changed Example to Examples, for consistency. Fixes rust-lang#13423
Substitute some VSCode variables in the VSCode client cc rust-lang/rust-analyzer#13405
E.g. TcpListener has
but the
handle_client
function isn't defined, and it's not particularly obvious what it should be, having something likein the code too would make it easier to interpret. (I'm sure this isn't the only example of this.)
The text was updated successfully, but these errors were encountered: