Edition 2024 now reports: argument requires that '1 must outlive 'static

[zh-jq-b]

I'm trying to test edition 2024 here by using branch https://github.com/bytedance/g3/tree/edition-2024, now some of the code reports

argument requires that `'1` must outlive `'static`

The toolchain version is

cargo 1.85.0-nightly (4c39aaff6 2024-11-25)

Code

The code is here: https://github.com/bytedance/g3, branch edition-2024.

cargo +nightly build -p g3-ctl

will give error at line https://github.com/bytedance/g3/blob/40d1e2e5946e701deb0a26d2e8342120a2fb89f5/lib/g3-ctl/src/opts.rs#L92

   Compiling g3-ctl v0.1.0 (/code/rust/g3/lib/g3-ctl)
error[E0521]: borrowed data escapes outside of method
  --> lib/g3-ctl/src/opts.rs:92:22
   |
86 |         &self,
   |         -----
   |         |
   |         `self` is a reference that is only valid in the method body
   |         let's call the lifetime of this reference `'1`
87 |         daemon_name: &'static str,
   |         ----------- `daemon_name` declared here, outside of the method body
...
92 |         let stream = self.connect_to_daemon(daemon_name).await?;
   |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |                      |
   |                      `self` escapes the method body here
   |                      argument requires that `'1` must outlive `'static`

For more information about this error, try `rustc --explain E0521`.
error: could not compile `g3-ctl` (lib) due to 1 previous error

And

cargo +nightly build -p g3-daemon

will give error at line https://github.com/bytedance/g3/blob/40d1e2e5946e701deb0a26d2e8342120a2fb89f5/lib/g3-daemon/src/control/local/mod.rs#L174

   Compiling g3-daemon v0.2.0 (/code/rust/g3/lib/g3-daemon)
error[E0521]: borrowed data escapes outside of associated function
   --> lib/g3-daemon/src/control/local/mod.rs:174:26
    |
168 |         daemon_name: &str,
    |         -----------  - let's call the lifetime of this reference `'1`
    |         |
    |         `daemon_name` is a reference that is only valid in the associated function body
...
174 |         let mut stream = LocalControllerImpl::connect_to_daemon(daemon_name, daemon_group).await?;
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |                          |
    |                          `daemon_name` escapes the associated function body here
    |                          argument requires that `'1` must outlive `'static`

error[E0521]: borrowed data escapes outside of associated function
   --> lib/g3-daemon/src/control/local/mod.rs:174:26
    |
169 |         daemon_group: &str,
    |         ------------  - let's call the lifetime of this reference `'2`
    |         |
    |         `daemon_group` is a reference that is only valid in the associated function body
...
174 |         let mut stream = LocalControllerImpl::connect_to_daemon(daemon_name, daemon_group).await?;
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |                          |
    |                          `daemon_group` escapes the associated function body here
    |                          argument requires that `'2` must outlive `'static`

For more information about this error, try `rustc --explain E0521`.
error: could not compile `g3-daemon` (lib) due to 2 previous errors

Version it worked on

Edition 2021

[fmease]

I presume you didn't run cargo fix --edition --workspace beforehand?

[fmease]

I'm pretty sure these anyhow::Result<impl AsyncRead + AsyncWrite> need to be turned into anyhow::Result<impl AsyncRead + AsyncWrite + use<>> to prevent the input lifetimes from getting captured.

If you did run cargo fix --edition --workspace and it did not add the + use<>, then that's a bug with the migration lints, otherwise it's a user error (you generally need to migrate to the next edition in some way, not just change the edition field).

[fmease]

I've cloned your project and executed cargo fix --edition --workspace. The migration changed 282 files (1438 insertions, 1451 deletions) and it did change the return type of async fn connect_to_daemon to anyhow::Result<impl AsyncRead + AsyncWrite + use<>> from anyhow::Result<impl AsyncRead + AsyncWrite> contrary to your edition-2024 branch.

[fmease]

After the cargo fix --edition --workspace, I completed the migration by cherry-picking the new commit from your edition-2024 branch which actually sets the edition to "2024" among other things. Lastly, I ran cargo check and cargo check --workspace on the freshly migrated project both of which succeeded.

Closing as user error.

Please see also https://doc.rust-lang.org/edition-guide/editions/transitioning-an-existing-project-to-a-new-edition.html

[zh-jq-b]

I presume you didn't run cargo fix --edition --workspace beforehand?

I did run this but found too many if let -> match changes that I don't want, so I revert the fix and try to change the code manually.

Though it's a user error, the error message given by the compiler can be improved?

[zh-jq-b]

I finished the migration by changing to the new impl Trait lifetime rules,
The necessary changes is only

19 files changed, 48 insertions(+), 37 deletions(-)

Is it possible to add a --necessary option to cargo fix --edition --workspace to only do required changes?