-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Put the doc language in the doc url #12604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This has pros and cons. If you use It's not as simple as 'put it in the URL' if you want to do it right. After a bunch of thought, https://github.com/jcasimir/locale_setter#how-it-works is what I came up with on this topic. |
This depends on the implementation. The user should be able to adjust that "correct language". |
Exactly. All I mean to say is that 'put the language in the URL' isn't a universal solution; there isn't one. |
@steveklabnik Which of the techniques you suggest can work with a static site? |
There is some work who have made for Support Mozilla and MDN. |
@brson depends on what you mean by 'static site.' The tiny bit of logic here should be able to be done in an nginx or apache config. Think mod_rewrite. |
cc our localization story in #12553 |
Assigning 1.0, P-low. (Felix would like to be able to hack on his urls to jump between french/english and between versions.) |
@darnuria I'm interested in seeing the MDN JavaScript code for locales. |
OK, after reading @steveklabnik's link here's my suggested plan of action:
In the future, once we know how to properly build and distribute internationalized docs, we can teach rustdoc to be multilocale and add links to the Since we don't need to have internationalized docs up for 1.0, not all of this needs to be done now. |
Though maybe we should pick either the URL args or the domain prefix, not both. |
Nominating for removal from 1.0. URL's can change later. |
Leaving as P-low, removing from 1.0 milestone list. No one wants to block the release on this issue. |
We have no i18n anymore, and so this isn't directly relevant. If and when we bring translations back, this is something that would need considered. |
internal: Simplify some completions
…thiaskrgr Prevent PR assignments to `@matthiaskrgr`, `@giraffate`, and `@Centri3` When commenting r? clippy, rustbot takes a random member from the team. I'm setting you kings and queen to be on vacation, so that rustbot doesn't target you. --- changelog: none cc: `@matthiaskrgr` `@giraffate` and `@Centri3`
As suggested in http://ericholscher.com/blog/2014/feb/27/how-i-judge-documentation-quality/, our doc URLs should be future-proofed for translation by putting 'en' somewhere in them. Nominating.
The text was updated successfully, but these errors were encountered: