Skip to content

Commit ec8345b

Browse files
committed
auto merge of #5407 : jbclements/rust/add-assert-eq-macro, r=jbclements
Adds an assert_eq! macro that asserts that its two arguments are equal. Error messages can therefore be somewhat more informative than a simple assert, because the error message includes "expected" and "given" values.
2 parents ed25a67 + 3cd65c2 commit ec8345b

18 files changed

+279
-296
lines changed

src/libcore/char.rs

+29-29
Original file line numberDiff line numberDiff line change
@@ -288,16 +288,16 @@ fn test_is_whitespace() {
288288

289289
#[test]
290290
fn test_to_digit() {
291-
fail_unless!(to_digit('0', 10u) == Some(0u));
292-
fail_unless!(to_digit('1', 2u) == Some(1u));
293-
fail_unless!(to_digit('2', 3u) == Some(2u));
294-
fail_unless!(to_digit('9', 10u) == Some(9u));
295-
fail_unless!(to_digit('a', 16u) == Some(10u));
296-
fail_unless!(to_digit('A', 16u) == Some(10u));
297-
fail_unless!(to_digit('b', 16u) == Some(11u));
298-
fail_unless!(to_digit('B', 16u) == Some(11u));
299-
fail_unless!(to_digit('z', 36u) == Some(35u));
300-
fail_unless!(to_digit('Z', 36u) == Some(35u));
291+
assert_eq!(to_digit('0', 10u), Some(0u));
292+
assert_eq!(to_digit('1', 2u), Some(1u));
293+
assert_eq!(to_digit('2', 3u), Some(2u));
294+
assert_eq!(to_digit('9', 10u), Some(9u));
295+
assert_eq!(to_digit('a', 16u), Some(10u));
296+
assert_eq!(to_digit('A', 16u), Some(10u));
297+
assert_eq!(to_digit('b', 16u), Some(11u));
298+
assert_eq!(to_digit('B', 16u), Some(11u));
299+
assert_eq!(to_digit('z', 36u), Some(35u));
300+
assert_eq!(to_digit('Z', 36u), Some(35u));
301301

302302
fail_unless!(to_digit(' ', 10u).is_none());
303303
fail_unless!(to_digit('$', 36u).is_none());
@@ -321,28 +321,28 @@ fn test_is_digit() {
321321
322322
#[test]
323323
fn test_escape_default() {
324-
fail_unless!(escape_default('\n') == ~"\\n");
325-
fail_unless!(escape_default('\r') == ~"\\r");
326-
fail_unless!(escape_default('\'') == ~"\\'");
327-
fail_unless!(escape_default('"') == ~"\\\"");
328-
fail_unless!(escape_default(' ') == ~" ");
329-
fail_unless!(escape_default('a') == ~"a");
330-
fail_unless!(escape_default('~') == ~"~");
331-
fail_unless!(escape_default('\x00') == ~"\\x00");
332-
fail_unless!(escape_default('\x1f') == ~"\\x1f");
333-
fail_unless!(escape_default('\x7f') == ~"\\x7f");
334-
fail_unless!(escape_default('\xff') == ~"\\xff");
335-
fail_unless!(escape_default('\u011b') == ~"\\u011b");
336-
fail_unless!(escape_default('\U0001d4b6') == ~"\\U0001d4b6");
324+
assert_eq!(escape_default('\n'), ~"\\n");
325+
assert_eq!(escape_default('\r'), ~"\\r");
326+
assert_eq!(escape_default('\''), ~"\\'");
327+
assert_eq!(escape_default('"'), ~"\\\"");
328+
assert_eq!(escape_default(' '), ~" ");
329+
assert_eq!(escape_default('a'), ~"a");
330+
assert_eq!(escape_default('~'), ~"~");
331+
assert_eq!(escape_default('\x00'), ~"\\x00");
332+
assert_eq!(escape_default('\x1f'), ~"\\x1f");
333+
assert_eq!(escape_default('\x7f'), ~"\\x7f");
334+
assert_eq!(escape_default('\xff'), ~"\\xff");
335+
assert_eq!(escape_default('\u011b'), ~"\\u011b");
336+
assert_eq!(escape_default('\U0001d4b6'), ~"\\U0001d4b6");
337337
}
338338
339339
340340
#[test]
341341
fn test_escape_unicode() {
342-
fail_unless!(escape_unicode('\x00') == ~"\\x00");
343-
fail_unless!(escape_unicode('\n') == ~"\\x0a");
344-
fail_unless!(escape_unicode(' ') == ~"\\x20");
345-
fail_unless!(escape_unicode('a') == ~"\\x61");
346-
fail_unless!(escape_unicode('\u011b') == ~"\\u011b");
347-
fail_unless!(escape_unicode('\U0001d4b6') == ~"\\U0001d4b6");
342+
assert_eq!(escape_unicode('\x00'), ~"\\x00");
343+
assert_eq!(escape_unicode('\n'), ~"\\x0a");
344+
assert_eq!(escape_unicode(' '), ~"\\x20");
345+
assert_eq!(escape_unicode('a'), ~"\\x61");
346+
assert_eq!(escape_unicode('\u011b'), ~"\\u011b");
347+
assert_eq!(escape_unicode('\U0001d4b6'), ~"\\U0001d4b6");
348348
}

src/libcore/cmp.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -172,10 +172,10 @@ pub pure fn max<T:Ord>(v1: T, v2: T) -> T {
172172
mod test {
173173
#[test]
174174
fn test_int() {
175-
fail_unless!(5.cmp(&10) == Less);
176-
fail_unless!(10.cmp(&5) == Greater);
177-
fail_unless!(5.cmp(&5) == Equal);
178-
fail_unless!((-5).cmp(&12) == Less);
179-
fail_unless!(12.cmp(-5) == Greater);
175+
assert_eq!(5.cmp(&10), Less);
176+
assert_eq!(10.cmp(&5), Greater);
177+
assert_eq!(5.cmp(&5), Equal);
178+
assert_eq!((-5).cmp(&12), Less);
179+
assert_eq!(12.cmp(-5), Greater);
180180
}
181181
}

0 commit comments

Comments
 (0)