Auto merge of #83314 - Aaron1011:print-unstable-value, r=lcnr

bors · bors · commit 61edfd591ced · 2021-03-20T16:20:21.000Z
Debug-print result when an unstable fingerprint is detected Helps with issues like #83311 I had previously tried to do this in #80692, but it had a significant performance impact (even though the code was never actually run). Hopefully, this will be better now that #79100 has been merged.
diff --git a/compiler/rustc_query_system/src/query/plumbing.rs b/compiler/rustc_query_system/src/query/plumbing.rs
@@ -590,7 +590,7 @@ fn incremental_verify_ich<CTX, K, V: Debug>(
 
     let old_hash = tcx.dep_graph().fingerprint_of(dep_node_index);
 
-    assert!(new_hash == old_hash, "found unstable fingerprints for {:?}", dep_node,);
+    assert!(new_hash == old_hash, "found unstable fingerprints for {:?}: {:?}", dep_node, result);
 }
 
 fn force_query_with_job<C, CTX>(

Original file line number	Diff line number	Diff line change
`@@ -590,7 +590,7 @@ fn incremental_verify_ich<CTX, K, V: Debug>(`
`590`	`590`
`591`	`591`	`let old_hash = tcx.dep_graph().fingerprint_of(dep_node_index);`
`592`	`592`
`593`		`- assert!(new_hash == old_hash, "found unstable fingerprints for {:?}", dep_node,);`
	`593`	`+ assert!(new_hash == old_hash, "found unstable fingerprints for {:?}: {:?}", dep_node, result);`
`594`	`594`	`}`
`595`	`595`
`596`	`596`	`fn force_query_with_job<C, CTX>(`