Skip to content

Commit 540a777

Browse files
committed
Don't ICE just because an impl is missing an associated type. Trust in the other compiler passes.
Fixes #17359.
1 parent c886894 commit 540a777

File tree

2 files changed

+29
-5
lines changed

2 files changed

+29
-5
lines changed

src/librustc/middle/traits/project.rs

+6-5
Original file line numberDiff line numberDiff line change
@@ -643,11 +643,12 @@ fn confirm_candidate<'cx,'tcx>(
643643
match impl_ty {
644644
Some(ty) => (ty, impl_vtable.nested.to_vec()),
645645
None => {
646-
selcx.tcx().sess.span_bug(
647-
obligation.cause.span,
648-
format!("impl `{}` did not contain projection for `{}`",
649-
impl_vtable.repr(selcx.tcx()),
650-
obligation.repr(selcx.tcx())).as_slice());
646+
// This means that the impl is missing a
647+
// definition for the associated type. This error
648+
// ought to be reported by the type checker method
649+
// `check_impl_items_against_trait`, so here we
650+
// just return ty_err.
651+
(selcx.tcx().types.err, vec!())
651652
}
652653
}
653654
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
2+
// file at the top-level directory of this distribution and at
3+
// http://rust-lang.org/COPYRIGHT.
4+
//
5+
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6+
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7+
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8+
// option. This file may not be copied, modified, or distributed
9+
// except according to those terms.
10+
11+
// Test that we do not ICE when an impl is missing an associated type (and that we report
12+
// a useful error, of course).
13+
14+
#![feature(associated_types)]
15+
16+
trait Trait {
17+
type Type;
18+
}
19+
20+
impl Trait for int {} //~ ERROR missing: `Type`
21+
22+
fn main() {}
23+

0 commit comments

Comments
 (0)