stabilize ci_rustc_if_unchanged_logic test

Signed-off-by: onur-ozkan <[email protected]>

Author: onur-ozkan

src/bootstrap/src/core/builder/tests.rs

@@ -214,8 +214,6 @@ fn alias_and_path_for_library() {
     assert_eq!(first(cache.all::<doc::Std>()), &[doc_std!(A => A, stage = 0)]);
 }
 
-// FIXME: This is failing in various runners in merge CI.
-#[ignore]
 #[test]
 fn ci_rustc_if_unchanged_logic() {
     let config = Config::parse_inner(
@@ -227,10 +225,6 @@ fn ci_rustc_if_unchanged_logic() {
         |&_| Ok(Default::default()),
     );
 
-    if config.rust_info.is_from_tarball() {
-        return;
-    }
-
     let build = Build::new(config.clone());
     let builder = Builder::new(&build);
 
@@ -240,26 +234,33 @@ fn ci_rustc_if_unchanged_logic() {
 
     builder.run_step_descriptions(&Builder::get_step_descriptions(config.cmd.kind()), &[]);
 
-    let compiler_path = build.src.join("compiler");
-    let library_path = build.src.join("library");
-
-    let commit =
-        get_closest_merge_commit(Some(&builder.config.src), &builder.config.git_config(), &[
-            compiler_path.clone(),
-            library_path.clone(),
-        ])
-        .unwrap();
-
-    let has_changes = !helpers::git(Some(&builder.src))
-        .args(["diff-index", "--quiet", &commit])
-        .arg("--")
-        .args([compiler_path, library_path])
-        .as_command_mut()
-        .status()
-        .unwrap()
-        .success();
-
-    assert!(has_changes == config.download_rustc_commit.is_none());
+    // Make sure "if-unchanged" logic doesn't try to use CI rustc while there are changes
+    // in compiler and/or library.
+    if config.download_rustc_commit.is_some() {
+        let compiler_path = build.src.join("compiler");
+        let library_path = build.src.join("library");
+
+        let commit =
+            get_closest_merge_commit(Some(&builder.config.src), &builder.config.git_config(), &[
+                compiler_path.clone(),
+                library_path.clone(),
+            ])
+            .unwrap();
+
+        let has_changes = !helpers::git(Some(&builder.src))
+            .args(["diff-index", "--quiet", &commit])
+            .arg("--")
+            .args([compiler_path, library_path])
+            .as_command_mut()
+            .status()
+            .unwrap()
+            .success();
+
+        assert!(
+            !has_changes,
+            "CI download can't be enabled from 'if-unchanged' while there are changes in compiler and/or library."
+        );
+    }
 }
 
 mod defaults {